Delta Virtual Airlines Issue Report #10

DEVELOPMENT ISSUE #10 - Name not remembered by Login Form
Reported by	James Brickell (DVA953) on 07/05/2005 09:35 ET
Assigned To	James Brickell (DVA953)
Issue Status	Fixed on 07/09/2005 12:17 ET
Issue Priority	Low
Airlines	Air France Virtual, Delta Virtual Airlines
Security	Public
Area	Web Site
Issue Type	Bug
Target Version	1.0
Issue Description	When I login and select "Remember my User ID" at next login, there is no data in the name field after I logout and click Login again. Firefox 1.0.4.
12 ISSUE COMMENTS
Luke Kolin (DVA043) 07/05/2005 10:14 ET	I'm seeing something similar. First name only, or both names? Take a peek at the end of LoginCommand, it should try and set two cookies called dva_fname and dva_lname. Does FF pop up a dialog that they're being set? (You may need to change your FF config to prompt on all cookies from our site) What's the expiration date of said cookies?
Luke Kolin (DVA043) 07/05/2005 10:51 ET	OK, it's definitely not setting the cookies. Look at the cookie setting code in LoginCommand near the end, it's checking the value of a field called saveInfo. Does the field exist on the JSP (login.jsp)?
James Brickell (DVA953) 07/05/2005 20:13 ET	Field does indeed exist, although I don't understand the checked="{!$empty dva_fname" attribute to the checkbox.
James Brickell (DVA953) 07/08/2005 00:36 ET	From the Java Docs: addCookie public void addCookie(Cookie cookie) Adds the specified cookie to the response. This method can be called multiple times to set more than one cookie. Parameters: cookie - the Cookie to return to the client Therefore shouldn't we be saying: ctx.getResponse().addCookie(Cookie lnc);
Luke Kolin (DVA043) 07/08/2005 00:40 ET	No, since lnc is already defined as being type cookie. If it wasn't, it wouldn't compile and you'd get an error. What I suspect is happening is a mismatch between the form values sent by the JSP, and the request parameters that the command is reading. Note line 113 of LoginCommand. I am calling Boolean.valueOf(String), which should take a string value and convert it into a Boolean. My guess is that we are expecting the string "true", but login.jsp has that checkbox returning a different value.
James Brickell (DVA953) 07/08/2005 00:44 ET	So in login.jsp we should change checked="${!empty dva_fname}" to checked=TRUE?
Luke Kolin (DVA043) 07/08/2005 00:51 ET	No, that will default that checkbox to always checked. Right now, it is checked if the value of dva_fname is not null, and I believe there is a tag earlier in that page to read a cookie value and store it in dva_fname. Is there a "value" parameter to that JSP tag? What is it set to?
James Brickell (DVA953) 07/08/2005 01:07 ET	Silly James..that would be your basic HTML. There is no value attribute to that JSP tag.
James Brickell (DVA953) 07/08/2005 01:14 ET	How do I go about updating code? Saving and emailing to you?
Luke Kolin (DVA043) 07/08/2005 10:20 ET	Hang on - my version has one. We're talking about the el:box tag, with a name of saveInfo, right? And yes, you can e-mail it to me. One of my projects for real soon now is installing Subversion on the server. The goal is to have all of the code (web site, installers, manuals) stored in subversion for version control and group development.
Luke Kolin (DVA043) 07/08/2005 10:51 ET	Look up the definition of Boolean.valueOf(String) in the Java API docs. The only thing it accepts as true is the string "true". My guess is that saveInfo is passing in a different value, namely "1".
James Brickell (DVA953) 07/08/2005 20:50 ET	I'm on the road right now, but yes, we are talking about the el:box if memory serves.

For flight simulation purposes only. Not a commercial website. In no way are we affiliated with Delta Air Lines, its affiliates, or any other airline. All logos, images, and trademarks remain the property of their respective owners. Delta Virtual Airlines is a non-profit entity engaged in providing an avenue for flight simulation enthusiasts.